projects
/
gbrg
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6b14a93
)
actortable: The demo actor table was reading out of bounds
author
Lukas Krickl
<lukas@krickl.dev>
Sat, 28 Jun 2025 16:55:28 +0000
(18:55 +0200)
committer
Lukas Krickl
<lukas@krickl.dev>
Sat, 28 Jun 2025 16:55:28 +0000
(18:55 +0200)
The laoder code was behaving correctly, but the size value was
off-by-one
BUGS.md
patch
|
blob
|
history
src/actortables.s
patch
|
blob
|
history
diff --git
a/BUGS.md
b/BUGS.md
index a2a242edcbda419e41deefb54bbf0b56168623fa..c7afc1df11186b5c1f28162d8b180d10d6663af3 100644
(file)
--- a/
BUGS.md
+++ b/
BUGS.md
@@
-1,9
+1,5
@@
# Known Bugs
-## Map actor loads are happening far out of bounds
-
-This causes random values being read as actor data.
-This bug only manifested itself as code went beyond 0x22a2.
diff --git
a/src/actortables.s
b/src/actortables.s
index 511da3df8f0be5062150465459f0aac3e23e022d..1479dbb8840a82ff8671f85fd2e005d9355f5d26 100644
(file)
--- a/
src/actortables.s
+++ b/
src/actortables.s
@@
-1,7
+1,7
@@
#include "unit_demo.s"
default_map_actor_table:
-.db 1
9
; size
+.db 1
8
; size
dw unit_demo_2
dw unit_demo_3
dw unit_demo_3