Fixed some linter warnings

diff --git a/src/ulas.c b/src/ulas.c
index a49b0d9fa6a88bf4f6cbd25f57abe1ac9e4a7471..dbf2ed303dbccdc5c11a2b71051d808b394068a1 100644 (file)
--- a/src/ulas.c
+++ b/src/ulas.c
@@ -46,7 +46,7 @@ void ulas_init(struct ulas_config cfg) {
   ulas.scope = 1;
 
   for (int i = 0; i < ULAS_CHARCODEMAPLEN; i++) {
-    ulas.charcodemap[i] = i;
+    ulas.charcodemap[i] = (char)i;
   }
 }
 
@@ -59,7 +59,7 @@ void ulas_nextpass(void) {
   ulas.filename = ulas.initial_filename;
 
   for (int i = 0; i < ULAS_CHARCODEMAPLEN; i++) {
-    ulas.charcodemap[i] = i;
+    ulas.charcodemap[i] = (char)i;
   }
 }
 
@@ -74,13 +74,13 @@ void ulas_free(void) {
 FILE *ulas_incpathfopen(const char *path, const char *mode) {
   char pathbuf[ULAS_PATHMAX];
   memset(pathbuf, 0, ULAS_PATHMAX);
-  int baselen = strlen(path);
+  unsigned long baselen = strlen(path);
 
   // check all include paths
   for (int i = 0; i < ulascfg.incpathslen; i++) {
     pathbuf[0] = '\0';
     char *ip = ulascfg.incpaths[i];
-    int len = strlen(ip);
+    unsigned long len = strlen(ip);
     if (len + baselen + 1 >= ULAS_PATHMAX) {
       continue;
     }

diff --git a/src/ulas.h b/src/ulas.h
index 0d6291b4576bd7076cbeae3e305abd5e41b58d8a..7e9a6f3429af2bbb71c02fe4b583ce8f774f1499 100644 (file)
--- a/src/ulas.h
+++ b/src/ulas.h
@@ -47,6 +47,7 @@
 #define ULAS_ASMSTR_PAD ".pad"
 #define ULAS_ASMSTR_INCBIN ".incbin"
 #define ULAS_ASMSTR_DEF ".def"
+// TODO: chksm should only work on sm83
 #define ULAS_ASMSTR_CHKSM ".chksm"
 #define ULAS_ASMSTR_ADV ".adv"
 #define ULAS_ASMSTR_SET_ENUM_DEF ".se"
@@ -77,7 +78,7 @@
     fprintf(ulaserr, __VA_ARGS__);                                             \
     exit(-1);                                                                  \
   }
-#define ULASWARNLEVEL(level) ulascfg.warn_level &(level)
+#define ULASWARNLEVEL(level) (ulascfg.warn_level &(level))
 
 // format macros
 #define ULAS_FMT(f, fmt)                                                       \