From: Lukas Krickl <lukas@krickl.dev>
Date: Fri, 17 Nov 2023 08:03:25 +0000 (+0100)
Subject: Removed remaining linter warnings
X-Git-Url: https://git.krickl.dev/?a=commitdiff_plain;h=fdaf540c2cd77020f3290b83e87516796680bea3;p=ulas%2F.git

Removed remaining linter warnings
---

diff --git a/.clang-tidy b/.clang-tidy
index e8c0c33..049204a 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -21,7 +21,9 @@ Checks: "*,
   -altera-id-dependent-backward-branch,
   -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
   -misc-no-recursion,
-  -concurrency-mt-unsafe
+  -concurrency-mt-unsafe,
+  -clang-analyzer-unix.Malloc,
+  -modernize-macro-to-enum
 "
 WarningsAsErrors: ''
 HeaderFilterRegex: ''
diff --git a/makefile b/makefile
index da26467..0fed56f 100644
--- a/makefile
+++ b/makefile
@@ -55,6 +55,10 @@ install:
 tags:
 	ctags --recurse=yes --exclude=.git --exclude=bin --exclude=obj --exclude=scripts
 
+.PHONY:
+ccmds:
+	bear -- make SHELL="sh -x -e" --always-make
+
 .PHONY: format
 format:
 	clang-format -i ./src/*.c ./include/*.h
@@ -63,5 +67,6 @@ format:
 lint:
 	clang-tidy ./include/*.h ./src/*.c
 
+.PHONY: runtest
 runtest:
 	./$(BDIR)/$(TEST_BNAME)
diff --git a/src/main.c b/src/main.c
index 48c959f..bb38dee 100644
--- a/src/main.c
+++ b/src/main.c
@@ -71,5 +71,9 @@ int main(int argc, char **argv) {
 
   int res = ulas_main(cfg);
 
+  if (cfg.output_path) {
+    free(cfg.output_path);
+  }
+
   return res;
 }
diff --git a/src/ulas.c b/src/ulas.c
index 5bb481d..5510227 100644
--- a/src/ulas.c
+++ b/src/ulas.c
@@ -56,7 +56,6 @@ int ulas_main(struct ulas_config cfg) {
     ulasout = fopen(cfg.output_path, "we");
     if (!ulasout) {
       fprintf(ulaserr, "%s: %s\n", cfg.output_path, strerror(errno));
-      free(cfg.output_path);
       return -1;
     }
   }
@@ -95,7 +94,6 @@ cleanup:
 
   if (cfg.output_path) {
     fclose(ulasout);
-    free(cfg.output_path);
   }
 
   if (cfg.argc > 0) {