From acb6833e0ae459bab2d8b36a0811ccdf260a28fb Mon Sep 17 00:00:00 2001
From: Lukas Krickl <lukas@krickl.dev>
Date: Sun, 18 Feb 2024 18:38:44 +0100
Subject: [PATCH] Fixed some linter warnings

---
 src/ulas.c | 8 ++++----
 src/ulas.h | 3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/ulas.c b/src/ulas.c
index a49b0d9..dbf2ed3 100644
--- a/src/ulas.c
+++ b/src/ulas.c
@@ -46,7 +46,7 @@ void ulas_init(struct ulas_config cfg) {
   ulas.scope = 1;
 
   for (int i = 0; i < ULAS_CHARCODEMAPLEN; i++) {
-    ulas.charcodemap[i] = i;
+    ulas.charcodemap[i] = (char)i;
   }
 }
 
@@ -59,7 +59,7 @@ void ulas_nextpass(void) {
   ulas.filename = ulas.initial_filename;
 
   for (int i = 0; i < ULAS_CHARCODEMAPLEN; i++) {
-    ulas.charcodemap[i] = i;
+    ulas.charcodemap[i] = (char)i;
   }
 }
 
@@ -74,13 +74,13 @@ void ulas_free(void) {
 FILE *ulas_incpathfopen(const char *path, const char *mode) {
   char pathbuf[ULAS_PATHMAX];
   memset(pathbuf, 0, ULAS_PATHMAX);
-  int baselen = strlen(path);
+  unsigned long baselen = strlen(path);
 
   // check all include paths
   for (int i = 0; i < ulascfg.incpathslen; i++) {
     pathbuf[0] = '\0';
     char *ip = ulascfg.incpaths[i];
-    int len = strlen(ip);
+    unsigned long len = strlen(ip);
     if (len + baselen + 1 >= ULAS_PATHMAX) {
       continue;
     }
diff --git a/src/ulas.h b/src/ulas.h
index 0d6291b..7e9a6f3 100644
--- a/src/ulas.h
+++ b/src/ulas.h
@@ -47,6 +47,7 @@
 #define ULAS_ASMSTR_PAD ".pad"
 #define ULAS_ASMSTR_INCBIN ".incbin"
 #define ULAS_ASMSTR_DEF ".def"
+// TODO: chksm should only work on sm83
 #define ULAS_ASMSTR_CHKSM ".chksm"
 #define ULAS_ASMSTR_ADV ".adv"
 #define ULAS_ASMSTR_SET_ENUM_DEF ".se"
@@ -77,7 +78,7 @@
     fprintf(ulaserr, __VA_ARGS__);                                             \
     exit(-1);                                                                  \
   }
-#define ULASWARNLEVEL(level) ulascfg.warn_level &(level)
+#define ULASWARNLEVEL(level) (ulascfg.warn_level &(level))
 
 // format macros
 #define ULAS_FMT(f, fmt)                                                       \
-- 
2.30.2